fix: AVWriter status 1 crash (#996)

* Fix AVWriter status 1 crash followup * Update RecordingSession.swift removing trailing semicolon to make linter happy * Update RecordingSession.swift Set hasRunningWritingAttempt to true * Update RecordingSession.swift * Update RecordingSession.swift * Update RecordingSession.swift * Update RecordingSession.swift Make the linter hate me again * Update RecordingSession.swift
mrousavy · May 23, 2022 · 83943da · 83943da
1 parent fce7994
commit 83943da
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/ios/RecordingSession.swift b/ios/RecordingSession.swift
@@ -33,6 +33,7 @@ class RecordingSession {
   private var initialTimestamp: CMTime?
   private var latestTimestamp: CMTime?
   private var hasWrittenFirstVideoFrame = false
+  private var isFinishing = false
 
   var url: URL {
     return assetWriter.outputURL
@@ -193,15 +194,22 @@ class RecordingSession {
   func finish() {
     ReactLogger.log(level: .info, message: "Finishing Recording with AssetWriter status \"\(assetWriter.status.descriptor)\"...")
 
+    if isFinishing {
+      ReactLogger.log(level: .warning, message: "Tried calling finish() twice while AssetWriter is still writing!")
+      return
+    }
+
     if !hasWrittenFirstVideoFrame {
       let error = NSError(domain: "capture/aborted",
                           code: 1,
                           userInfo: [NSLocalizedDescriptionKey: "Stopped Recording Session too early, no frames have been recorded!"])
       completionHandler(self, .failed, error)
     } else if assetWriter.status == .writing {
+      isFinishing = true
+      bufferAdaptor?.assetWriterInput.markAsFinished()
+      audioWriter?.markAsFinished()
       assetWriter.finishWriting {
-        self.bufferAdaptor?.assetWriterInput.markAsFinished()
-        self.audioWriter?.markAsFinished()
+        self.isFinishing = false
         self.completionHandler(self, self.assetWriter.status, self.assetWriter.error)
       }
     } else {