fix: Fix Frame Processor null-dereference error (use ref-counted JNI …

…`local_ref`) (#351)
mrousavy · Aug 20, 2021 · d06bcf6 · d06bcf6
1 parent cae08a1
commit d06bcf6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/android/src/main/cpp/FrameProcessorPlugin.cpp b/android/src/main/cpp/FrameProcessorPlugin.cpp
@@ -11,7 +11,7 @@ using namespace facebook;
 using namespace jni;
 
 using TSelf = local_ref<HybridClass<FrameProcessorPlugin>::jhybriddata>;
-using TFrameProcessorPlugin = jobject(alias_ref<JImageProxy::javaobject>, alias_ref<JArrayClass<jobject>>);
+using TFrameProcessorPlugin = jobject(local_ref<JImageProxy::javaobject>, local_ref<JArrayClass<jobject>>);
 
 TSelf vision::FrameProcessorPlugin::initHybrid(alias_ref<HybridClass::jhybridobject> jThis, const std::string& name) {
   return makeCxxInstance(jThis, name);
@@ -24,7 +24,7 @@ void FrameProcessorPlugin::registerNatives() {
   });
 }
 
-local_ref<jobject> FrameProcessorPlugin::callback(alias_ref<JImageProxy::javaobject> image, alias_ref<JArrayClass<jobject>> params) {
+local_ref<jobject> FrameProcessorPlugin::callback(local_ref<JImageProxy::javaobject> image, local_ref<JArrayClass<jobject>> params) {
   static const auto func = javaPart_->getClass()->getMethod<TFrameProcessorPlugin>("callback");
   auto result = func(javaPart_.get(), image, params);
   return make_local(result);

diff --git a/android/src/main/cpp/FrameProcessorPlugin.h b/android/src/main/cpp/FrameProcessorPlugin.h
@@ -22,7 +22,7 @@ class FrameProcessorPlugin: public HybridClass<FrameProcessorPlugin> {
                                                 const std::string& name);
   static void registerNatives();
 
-  local_ref<jobject> callback(alias_ref<JImageProxy::javaobject> image, alias_ref<JArrayClass<jobject>> params);
+  local_ref<jobject> callback(local_ref<JImageProxy::javaobject> image, local_ref<JArrayClass<jobject>> params);
   std::string getName();
 
  private: