fix: Fix divison by zero in Performance Sample collector (#416)

* fix: Fix divison by zero in Performance Sample collector * use `isEmpty`
mrousavy · Sep 8, 2021 · f9dbb69 · f9dbb69
1 parent 4726639
commit f9dbb69
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/ios/CameraView+RecordVideo.swift b/ios/CameraView+RecordVideo.swift
@@ -236,6 +236,7 @@ extension CameraView: AVCaptureVideoDataOutputSampleBufferDelegate, AVCaptureAud
   private func evaluateNewPerformanceSamples() {
     lastFrameProcessorPerformanceEvaluation = DispatchTime.now()
     guard let videoDevice = videoDeviceInput?.device else { return }
+    guard frameProcessorPerformanceDataCollector.hasEnoughData else { return }
 
     let maxFrameProcessorFps = Double(videoDevice.activeVideoMinFrameDuration.timescale) * Double(videoDevice.activeVideoMinFrameDuration.value)
     let averageFps = 1.0 / frameProcessorPerformanceDataCollector.averageExecutionTimeSeconds

diff --git a/ios/Frame Processor/FrameProcessorPerformanceDataCollector.swift b/ios/Frame Processor/FrameProcessorPerformanceDataCollector.swift
@@ -28,6 +28,10 @@ class FrameProcessorPerformanceDataCollector {
   private var counter = 0
   private var lastEvaluation = -1
 
+  var hasEnoughData: Bool {
+    return !performanceSamples.isEmpty
+  }
+
   var averageExecutionTimeSeconds: Double {
     let sum = performanceSamples.reduce(0, +)
     let average = sum / Double(performanceSamples.count)