Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Mirror selfie images on Android #74

Closed
mrousavy opened this issue Mar 17, 2021 · 0 comments · Fixed by #129
Closed

✨ Mirror selfie images on Android #74

mrousavy opened this issue Mar 17, 2021 · 0 comments · Fixed by #129
Assignees
Labels
🤖 android Issue affects the Android platform

Comments

@mrousavy
Copy link
Owner

mrousavy commented Mar 17, 2021

Selfie images are correctly mirrored (horizontally flipped) on iOS, but not on Android. This is due to the fact that this is not possible with CameraX without additional overhead.

https://github.com/cuvent/react-native-vision-camera/blob/dff8fc71788311c324e6eb80976a6ec50596d3e5/android/src/main/java/com/mrousavy/camera/CameraView%2BTakePhoto.kt#L59

I have tried to implement this in-memory, but sadly it didn't work:

https://github.com/cuvent/react-native-vision-camera/blob/03b9246afee58828eabb1b87173bdc985478cc4a/android/src/main/java/com/mrousavy/camera/utils/ImageProxy.save.kt#L11-L34

@mrousavy mrousavy added enhancement 🤖 android Issue affects the Android platform labels Mar 17, 2021
@mrousavy mrousavy self-assigned this Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 android Issue affects the Android platform
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant