Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR automatically horizontally flips (= mirrors) images taken from the front camera.
It is achieved by decoding the received
byte[]
to aBitmap
, applying a Matrix with a scaleX of-1
, then converting it back to abyte[]
. I am not fully happy with that approach, as I'd like to avoid thebyte[]
->Bitmap
->byte[]
approach if possible.Benchmarks show that horizontally flipping an image takes ~24ms on my Huawai P10.
Back camera (no flipping):
Front camera (flipping):
Changes
flipImage
to ImageProxy+save - a function that flips the given byte[].flipImage
in ImageProxy+save whenflipHorizontally
ist trueSide-effects
Tested on
Related issues
Closes #74