Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (V2) Android build problem for static minSdkVersion #1835

Closed
wants to merge 1 commit into from

Conversation

KarlosQ
Copy link

@KarlosQ KarlosQ commented Sep 22, 2023

What

This PR fixes Android build for a static minSdkVersion.

Changes

This PR changes minSdkVersion value from 21 to getExtOrIntegerDefault('minSdkVersion')

Tested on

Android with this config (RN 0.71.13):

buildToolsVersion = "33.0.0"
minSdkVersion = 23
compileSdkVersion = 33
targetSdkVersion = 33

Related issues

stemyke comment #1814

@vercel
Copy link

vercel bot commented Sep 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-vision-camera ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2023 9:39am

@KarlosQ KarlosQ changed the title Fix Android build problem for static minSdkVersion fix: (V2) Android build problem for static minSdkVersion Sep 22, 2023
@mrousavy
Copy link
Owner

Nice!

@mrousavy
Copy link
Owner

Hey sorry for long radio silence here but thanks for your PR! We no longer have this code so this is obsolete I think.. sorry!

@mrousavy mrousavy closed this Sep 30, 2023
@KarlosQ KarlosQ deleted the fix/android-build-min-sdk branch October 2, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants