fix: Unbind Camera in onDetachedFromWindow and fix minSdkVersion #1955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
good point! |
|
Hey, thanks for your PR - unfortunately the build failed. Can you fix that? Otherwise we're good to go!
|
mrousavy
changed the title
5 tasks
|
okay whatever I'll do it myself. |
mrousavy
pushed a commit
that referenced
this pull request
Feb 8, 2024
j-piasecki
pushed a commit
to j-piasecki/react-native-vision-camera
that referenced
this pull request
Feb 12, 2024
…usavy#1955) * fix: camera session is bound and idle on unmount * fix: abiFilters do not read from gradle.properties * fix: minSdkVersion does not read from root project * fix: FOR_HERMES null is truthy
j-piasecki
pushed a commit
to j-piasecki/react-native-vision-camera
that referenced
this pull request
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR fixes camera device and session resource cleanup when unmounted for Android devices. Additionally this build resolves a number of build issues relating to reading project configuration.
Changes
onDetachedFromWindow.minSdkVersioninandroid/build.gradleto read from root project.FOR_HERMESinandroid/build.gradleto read from root project.abiFiltersinandroid/build.gradleto read fromgradle.properties.Tested on
Samsung S10-S22, Samsung XCover Pro V3-6, Pixel 3a-6
Related issues