fix: Fix for inset of SENSOR_INFO_ACTIVE_ARRAY_SIZE for Android < 11 #2306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
lol, interesting! nice catch man, thanks for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
On my Nokia 7.1 the SENSOR_INFO_ACTIVE_ARRAY_SIZE rect has an offset of 8px (Rect(8, 8 - 4040, 3032)).
This leads to a camera disconnect if the codeScanner is used.
Changes
This PR just subtracts the left and top offset so that the new rect starts at 0,0.
Tested on
Nokia 7.1, Android 10
Related issues
Possible fix for: #2257