Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable precapture sequence by default #2629

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

mrousavy
Copy link
Owner

@mrousavy mrousavy commented Mar 4, 2024

What

Disables the precapture pipeline by default, and allows the user to enable it again using the enablePrecapture parameter in takePhoto.

The precapture sequence is used for properly locking AE, AF and AWB values to a good state before shooting the photo, but apparently it broke on some Samsung devices, and I have no idea why.

Changes

Tested on

Related issues

Copy link

vercel bot commented Mar 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-native-vision-camera ✅ Ready (Inspect) Visit Preview Mar 4, 2024 11:37am

@mrousavy mrousavy merged commit 3f1a7c9 into main Mar 4, 2024
7 checks passed
@mrousavy mrousavy deleted the fix/disable-precapture-by-default branch March 4, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant