Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auto focus/exposure by default #2970

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

j-jonathan
Copy link
Contributor

What

On some iOS devices (e.g. on my iPod) the auto focus/exposure is not enabled by default. The focus/exposure is done when the camera is loaded and does not change afterwards.

Changes

Enable the auto focus/exposure when a format is loaded.

Tested on

  • iPhone 12, iOS 17.4.1
  • iPad Air 2, iOS 15.8.2
  • iPod, iOS 12.5.7

Copy link

vercel bot commented Jun 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-vision-camera ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 2:55pm

@mrousavy
Copy link
Owner

oh wow interesting! is that really the case? I thought it was always continuous by default...

@mrousavy
Copy link
Owner

Does that need to be done in configureFormat? What if no Format is selected?

@j-jonathan
Copy link
Contributor Author

j-jonathan commented Jun 12, 2024

Yeah :( At least that's the case on my iPod.

And once, I had the case where the continuous autofocus/autoexposure (i don't remember which one) was not available, so it's important to test first if it's available otherwise it crashs.

Does that need to be done in configureFormat? What if no Format is selected?

Yeah, i don't know if i made the fix at the right place ^^

@mrousavy
Copy link
Owner

I just pushed another commit - can you test if this still works fine on your iPod?

@mrousavy mrousavy merged commit 89a8806 into mrousavy:main Jun 12, 2024
8 checks passed
@j-jonathan
Copy link
Contributor Author

I will test that tomorrow :)
Thank you!

@j-jonathan
Copy link
Contributor Author

I just tested on my iPod and it works perfectly fine 😊

@mrousavy
Copy link
Owner

nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants