-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added RGBA support for Android. #64
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey!
Thank you so much for your PR, that's pretty dope.
I wanna have a few changes in that code though.
- Instead of passing the Image format to C++ with a custom created enum, we can just get the format of the
JImage
on the native side. Please use that approach instead, so inJImage
we just add aint getFormat()
method and compare it with the C++ Image Format types (HardwareBuffer maybe). - Instead of creating two functions in C++, we just stick to one single function (called
imageToFrameBuffer
) and add a switch in there. To me that sounds more logical - Any chance we can have iOS support in there?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
Looking forward to the new release with this support for Android ❤️ |
I'm not sure about C++ and Kotlin practices, but I added function that performs RGBA -> ARGB frame buffer conversion. This way, you can use resize plugin with Skia Frame processor from vision camera v4.