Update CI tools and images #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madddi
force-pushed
the
update-ci-tools-and-tests
branch
4 times, most recently
from
51b3c6b
to
618b77d
Compare
madddi
force-pushed
the
update-ci-tools-and-tests
branch
from
618b77d
to
f6f06da
Compare
|
@mrparkers I've modified the CI config to test multiple versions (#111)... Unfortunately CircleCI seems to be somewhat limited for this kind of use case. Maybe you can have a look at the config and tell me what you think |
|
Nice work! I think the approach you used is solid. Testing the latest two major versions is probably fine, I think it's reasonable to assume that most users will be using one of them. I can take a look at updating the Terraform SDK some other time, thanks for the effort! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the tool versions used in CircleCI and local acceptance tests:
osixia/openldap:1.2.2->osixia/openldap:1.3.0postgres:9.6->postgres:12Also fixes a small typo in an error message.
This PR intentionally leaves Terraform at version 0.12.1. I tried upgrading it to 0.12.18 but this breaks a lot of tests. Error messages look different, validation is different and it seems to trigger race conditions in KeyCloak... I suggest to do this upgrade in a separate PR.