Album covers broken

[ph03]

Hi!

I get
Traceback (most recent call last):
File "/usr/bin/spotify-dbus.py", line 274, in change_listener
self.show_playing()
File "/usr/bin/spotify-dbus.py", line 130, in show_playing
self.nid = interface.Notify('Spotify', 0, self.get_cover(), self.get_info(track, 'title'), text, actions, hints, self.timeout)
File "/usr/bin/spotify-dbus.py", line 410, in get_cover
os.system('wget -q -O ' + path + ' ' + match.group(0))
AttributeError: 'NoneType' object has no attribute 'group'

On album cover query.

I fixed it temporarily by adding a

        if not match:
            path = '/usr/share/pixmaps/spotify.png'
            if self.debug == True:
                print "Download cover failed..."
            return path

after the regex match at line 404. It would be nice if this could be fixed. I guess the image url has changed in a newer spotify version. I'm using media-sound/spotify-0.8.8.323-r1 on gentoo.

[frederic-romagne]

Checked the text returned by curl, the page indeed changed, this patch fixes it.
--- /usr/bin/spotify-dbus.py 2012-11-20 19:23:35.000000000 +0100
+++ ./spotify-dbus.py 2013-01-14 14:45:32.778764654 +0100
@@ -400,7 +400,7 @@
# Generate cover URL
id = track['xesam:url'].split(':')
url = 'http://open.spotify.com/track/' + id[2]

•                   output = commands.getoutput('curl -v ' + url + '| grep \'id="cover-art"\'')
  

•                   output = commands.getoutput('curl -v ' + url + '| grep \'property="og:image"\'')
                    match = re.search('http(.+)image\/(\w+)', output)
  

                    # Download the cover

[ph03]

Nice, this works! :) Will you be able to commit this?

[mrpdaemon]

Thanks, committed the fix at 55ce7a3

[ph03]

I'm afraid this issue has returned..

Traceback (most recent call last):
  File "/usr/bin/spotify-dbus.py", line 295, in change_listener
    self.show_playing()
  File "/usr/bin/spotify-dbus.py", line 137, in show_playing
    self.nid = interface.Notify('Spotify', 0, self.get_cover(), self.get_info(track, 'title'), text, actions, hints, self.timeout)
  File "/usr/bin/spotify-dbus.py", line 417, in get_cover
    os.system('wget -q -O ' + path + ' ' + match.group(0))
AttributeError: 'NoneType' object has no attribute 'group'

I'm using the gentoo version equivalent to 20130119 .

Interrestengly, most of the time cover fetching works and only sometimes fails.
I worked around this issue it in the pull request with hash 98768c7.