MixIn attribute not compiling when ImplicitUsings is disabled: Fixes #36

(#37)
mrpmorris · Sep 22, 2023 · bf58a46 · bf58a46
1 parent 56c4fe6
commit bf58a46
Show file tree

Hide file tree

Showing 6 changed files with 27 additions and 25 deletions.
diff --git a/Docs/releases.md b/Docs/releases.md
@@ -1,5 +1,8 @@
 # Releases
 
+## New in 1.8
+* Fix: When `ImplicitUsings` is disabled for a project, the attribute for a MixIn won't compile [Fixes #36](https://github.com/mrpmorris/Morris.Moxy/issues/36). 
+
 ## New in 1.7
 * Fix: Moxy stops generating code when @moxy header is malformed [Fixes #33](https://github.com/mrpmorris/Morris.Moxy/issues/33)
 

diff --git a/Publish.bat b/Publish.bat
@@ -1,15 +1,15 @@
 cls
-@echo **** 1.6.0 : UPDATED THE VERSION NUMBER IN THE PROJECT *AND* BATCH FILE? ****
+@echo **** 1.8.0 : UPDATED THE VERSION NUMBER IN THE PROJECT *AND* BATCH FILE? ****
 pause
 
 cls
 @call BuildAndTest.bat
 
 @echo ======================
 
-set /p ShouldPublish=Publish 1.6.0 [yes]?
+set /p ShouldPublish=Publish 1.8.0 [yes]?
 @if "%ShouldPublish%" == "yes" (
 	@echo PUBLISHING
-	dotnet nuget push .\Source\Lib\Morris.Moxy\bin\Release\Morris.Moxy.1.6.0.nupkg -k %MORRIS.NUGET.KEY% -s https://api.nuget.org/v3/index.json
+	dotnet nuget push .\Source\Lib\Morris.Moxy\bin\Release\Morris.Moxy.1.8.0.nupkg -k %MORRIS.NUGET.KEY% -s https://api.nuget.org/v3/index.json
 )
 
diff --git a/Source/Lib/Morris.Moxy/SourceGenerators/TemplateAttributeSourceGenerator.cs b/Source/Lib/Morris.Moxy/SourceGenerators/TemplateAttributeSourceGenerator.cs
@@ -75,8 +75,8 @@ private static void GenerateClassSource(ParsedTemplate parsedTemplate, IndentedT
 			writer.WriteLine($"using {attributeUsingClause};");
 		writer.WriteLine();
 
-		writer.WriteLine("[AttributeUsage(AttributeTargets.Class | AttributeTargets.Struct, AllowMultiple = true)]");
-		writer.WriteLine($"internal class {parsedTemplate.Name}Attribute : Attribute");
+		writer.WriteLine("[System.AttributeUsage(System.AttributeTargets.Class | System.AttributeTargets.Struct, AllowMultiple = true)]");
+		writer.WriteLine($"internal class {parsedTemplate.Name}Attribute : System.Attribute");
 		using (writer.CodeBlock())
 		{
 			GenerateClassProperties(parsedTemplate, writer);

diff --git a/Source/Tutorials/01-MixInAMethod/MixInAMethod/MixInAMethod.csproj b/Source/Tutorials/01-MixInAMethod/MixInAMethod/MixInAMethod.csproj
@@ -1,24 +1,23 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
-  <PropertyGroup>
-	<OutputType>Exe</OutputType>
-	<TargetFramework>net6.0</TargetFramework>
-  <ImplicitUsings>enable</ImplicitUsings>
-	<Nullable>enable</Nullable>
-	<EmitCompilerGeneratedFiles>true</EmitCompilerGeneratedFiles>
-	<RootNamespace>$(MSBuildProjectName.Replace(" ", "_"))</RootNamespace>
-  </PropertyGroup>
+	<PropertyGroup>
+		<OutputType>Exe</OutputType>
+		<TargetFramework>net6.0</TargetFramework>
+		<Nullable>enable</Nullable>
+		<EmitCompilerGeneratedFiles>true</EmitCompilerGeneratedFiles>
+		<RootNamespace>$(MSBuildProjectName.Replace(" ", "_"))</RootNamespace>
+	</PropertyGroup>
 
-  <ItemGroup>
-    <None Remove="Mixins\SayHello.mixin" />
-  </ItemGroup>
+	<ItemGroup>
+		<None Remove="Mixins\SayHello.mixin" />
+	</ItemGroup>
 
-  <ItemGroup>
-    <AdditionalFiles Include="Mixins\SayHello.mixin" />
-  </ItemGroup>
- 
-  <ItemGroup>
-    <ProjectReference Include="..\..\..\Lib\Morris.Moxy\Morris.Moxy.csproj" OutputItemType="Analyzer" ReferenceOutputAssembly="false" />
-  </ItemGroup>
+	<ItemGroup>
+		<AdditionalFiles Include="Mixins\SayHello.mixin" />
+	</ItemGroup>
+
+	<ItemGroup>
+		<ProjectReference Include="..\..\..\Lib\Morris.Moxy\Morris.Moxy.csproj" OutputItemType="Analyzer" ReferenceOutputAssembly="false" />
+	</ItemGroup>
 
 </Project>
diff --git a/Source/Tutorials/01-MixInAMethod/MixInAMethod/Mixins/SayHello.mixin b/Source/Tutorials/01-MixInAMethod/MixInAMethod/Mixins/SayHello.mixin
@@ -4,7 +4,7 @@
     {
       public void SayHello()
       {
-        Console.WriteLine("Hello");
+        System.Console.WriteLine("Hello");
       }
     }
 }
diff --git a/Source/Tutorials/01-MixInAMethod/MixInAMethod/Program.cs b/Source/Tutorials/01-MixInAMethod/MixInAMethod/Program.cs
@@ -2,7 +2,7 @@
 
 using MixInAMethod;
 
-Console.WriteLine("Hello, World!");
+System.Console.WriteLine("Hello, World!");
 
 var person = new Person();
 person.SayHello();