New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port list download code to JS #25
Conversation
The names |
Hmm... Let me revert the name changes then. Edit: But wait, aren't they generated by the shell scripts and we already updated them? |
Fair enough. I didn't notice that. There's still a probability that the script's going to break for people using their own lists though.
No need to revert them, just dynamically adjust the name of files being used based on which one exists. You can use |
So here it is 😁 |
May want to add to the README that these scripts support hosts, domain and adblock formats but work best with wildcard domain (without asterisk) format now. |
Thanks! I’m feeling guilty for burdening you with so many requests, but there’s one more tiny thing. Could you please make it so that the download_lists Node script grabs both allowlists and blocklists when it’s run with no arguments? That’d be good for convenience. |
…ad script execution without arguments
Alright. Those requests just make the scripts work better so there's nothing guilty. |
Thanks for contributing so much :) |
I wish I could remove all the shell scripts but for the sake of compatibility 🥲