fix: use Default .SemVer when git version tag property is not calculable #53
Conversation
WalkthroughThis update focuses on refining the versioning process within the Changes
Possibly related issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (1)
- apps/semver-yeasy/semver-yeasy.sh (4 hunks)
Additional comments not posted (2)
apps/semver-yeasy/semver-yeasy.sh (2)
96-102: > 📝 NOTEThis review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [9-15]
Several
GITVERSION_TAG_PROPERTY_*andGITVERSION_CONFIG_SINGLE_APPvariables appear unused. Verify their usage or export them if they are used externally.
99-99: SettingGITVERSION_TAG_PROPERTYto a default value when it's empty is a crucial fix. However, ensure that the logic for determining the property name and its assignment is consistent and error-free across the script.Also applies to: 131-131, 186-186, 213-213
| GITVERSION_TAG_PROPERTY=${!GITVERSION_TAG_PROPERTY_NAME} | ||
|
|
||
| if [ "${GITVERSION_TAG_PROPERTY}" == "" ]; then | ||
| GITVERSION_TAG_PROPERTY_NAME="GITVERSION_TAG_PROPERTY_DEFAULT" | ||
| GITVERSION_TAG_PROPERTY=${GITVERSION_TAG_PROPERTY_DEFAULT} | ||
| fi | ||
|
|
||
| service_version=$(echo "${gitversion_calc}" | ${JQ_EXEC_PATH} -r "[${GITVERSION_TAG_PROPERTY}] | join(\"\")") |
There was a problem hiding this comment.
📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [6-6]
The use of tr with square brackets around classes is unnecessary and can be simplified. Also, consider wrapping $2 in double quotes to prevent globbing and word splitting.
- repo_type="$(echo $2 | tr '[[:lower:]]' '[[:upper:]]')"
+ repo_type="$(echo "$2" | tr '[:lower:]' '[:upper:]')"📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [22-22]
Consider wrapping $GITHUB_OUTPUT in double quotes to prevent globbing and word splitting.
- echo "$@" >> $GITHUB_OUTPUT
+ echo "$@" >> "$GITHUB_OUTPUT"📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [66-66]
When assigning arrays from command outputs, prefer using mapfile or read -a to avoid issues with word splitting and to handle non-alphanumeric filenames more robustly.
- changed_services=(`ls -1 apps | xargs -n 1 printf 'apps/%s\n'`)
+ mapfile -t changed_services < <(ls -1 apps | xargs -n 1 printf 'apps/%s\n')For the git diff command output parsing, consider a similar approach or ensure proper quoting.
Also applies to: 75-75, 77-77
📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [95-95]
In several places, the script uses tr with unnecessary square brackets around classes. Simplify these expressions by removing the square brackets.
- GITVERSION_TAG_PROPERTY_NAME="GITVERSION_TAG_PROPERTY_$(echo "${DIFF_SOURCE}" | sed 's|/.*$||' | tr '[[:lower:]]' '[[:upper:]]')"
+ GITVERSION_TAG_PROPERTY_NAME="GITVERSION_TAG_PROPERTY_$(echo "${DIFF_SOURCE}" | sed 's|/.*$||' | tr '[:lower:]' '[:upper:]')"Also applies to: 128-128, 182-182, 209-209
mrsauravsahu
deleted the
fix/50-version-calc-during-push-events-with-event
branch
Summary by CodeRabbit
GITVERSION_TAG_PROPERTYin versioning script, fixing issues with service version retrieval when the property is unset.