Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #3

Closed
MrSpiffyClean opened this issue May 8, 2020 · 0 comments
Closed

Improvements #3

MrSpiffyClean opened this issue May 8, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@MrSpiffyClean
Copy link
Owner

After some review, the only 'object' that doesn't trigger a recount/relist of all selected countries is the 'Select Region' selectbox. This is because whenever it changes, it reverts to the 'default' selection (i.e. notable countries/locations, the 10 with most cases).
With this being said, then the whole naming scheme I had in the start of the branch becomes mute, as both select and checkboxes trigger the relist.

The idea is then as follows:

  • Rename createURLFromSelect to createURLFromRegion, and have the region selectbox the only one calling this.
  • Everything else calls a... createURLFromChange (renaming the previous createURLFromCheckbox)
  • checkbox function parameter changed to change. The biggest issue here is communicating what exactly change is, because changing a region is also change of sorts... For the time being, I don't see a good name.
@MrSpiffyClean MrSpiffyClean added the enhancement New feature or request label May 8, 2020
@MrSpiffyClean MrSpiffyClean self-assigned this May 8, 2020
MrSpiffyClean added a commit that referenced this issue May 8, 2020
MrSpiffyClean added a commit that referenced this issue May 8, 2020
Check #3 for details.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant