You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After some review, the only 'object' that doesn't trigger a recount/relist of all selected countries is the 'Select Region' selectbox. This is because whenever it changes, it reverts to the 'default' selection (i.e. notable countries/locations, the 10 with most cases).
With this being said, then the whole naming scheme I had in the start of the branch becomes mute, as both select and checkboxes trigger the relist.
The idea is then as follows:
Rename createURLFromSelect to createURLFromRegion, and have the region selectbox the only one calling this.
Everything else calls a... createURLFromChange (renaming the previous createURLFromCheckbox)
checkbox function parameter changed to change. The biggest issue here is communicating what exactly change is, because changing a region is also change of sorts... For the time being, I don't see a good name.
The text was updated successfully, but these errors were encountered:
After some review, the only 'object' that doesn't trigger a recount/relist of all selected countries is the 'Select Region' selectbox. This is because whenever it changes, it reverts to the 'default' selection (i.e. notable countries/locations, the 10 with most cases).
With this being said, then the whole naming scheme I had in the start of the branch becomes mute, as both select and checkboxes trigger the relist.
The idea is then as follows:
checkbox
function parameter changed tochange
. The biggest issue here is communicating what exactly change is, because changing a region is also change of sorts... For the time being, I don't see a good name.The text was updated successfully, but these errors were encountered: