Added tests to make sure we throw exceptions if we are passed null or…

… empty strings.
mrstebo · Sep 20, 2018 · 8b8ff5e · 8b8ff5e
1 parent 357bbdd
commit 8b8ff5e
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/src/FakerDotNet/Fakers/FakeFaker.cs b/src/FakerDotNet/Fakers/FakeFaker.cs
@@ -20,6 +20,8 @@ public FakeFaker(IFakerContainer fakerContainer)
 
         public string F(string format)
         {
+            if (string.IsNullOrEmpty(format)) throw new FormatException("A string must be specified");
+
             var result = format;
             Match match;
             while ((match = Regex.Match(result, @"\{(\w+).(\w+)\}")).Success)

diff --git a/tests/FakerDotNet.Tests/Fakers/FakeFakerTests.cs b/tests/FakerDotNet.Tests/Fakers/FakeFakerTests.cs
@@ -40,6 +40,24 @@ public void F_handles_duplicate_placeholders()
             Assert.AreEqual("Test1 Test2", _fakeFaker.F(format));
         }
 
+        [Test]
+        public void F_with_null_throws_FormatException()
+        {
+            var ex = Assert.Throws<FormatException>(() => _fakeFaker.F(null));
+
+            Assert.AreEqual("A string must be specified", ex.Message);
+        }
+
+        [Test]
+        public void F_with_empty_string_throws_FormatException()
+        {
+            const string format = "";
+
+            var ex = Assert.Throws<FormatException>(() => _fakeFaker.F(format));
+
+            Assert.AreEqual("A string must be specified", ex.Message);
+        }
+
         [Test]
         public void F_with_invalid_faker_throws_FormatException()
         {