timeout for whole rest operations

[69736c616d]

here is the simple patch for timeout.

[mrtazz]

thank you for submitting this pull request and sorry for the wait. Could you remove the DS_Store files and add some unit tests around the functionality so I don't accidentally break it in future commits?

[mrtazz]

Sorry for the delay here. I just changed the tests for running against httpbin. Would you mind merging master into your pull request and writing a test to run against http://httpbin.org/delay/10 or something with the right timeout settings?

[69736c616d]

ok, i will check out that.

Greetings
iyasar

On 10-08-2015 01:03, Daniel Schauenberg wrote:

Sorry for the delay here. I just changed the tests for running against
httpbin. Would you mind merging master into your pull request and
writing a test to run against http://httpbin.org/delay/10 or something
with the right timeout settings?

—
Reply to this email directly or view it on GitHub
#14 (comment).

[69736c616d]

corrected code where test cases fail.

[69736c616d]

checking other issues,

[69736c616d]

i think, it is done

[mrtazz]

@69736c616d thanks for the quick update! I would still love to have some tests for the new functionality against the httpbin endpoint I mentioned. This is important for two reasons:

1. I don't want to accidentally break functionality in the future
2. There should be a documented way of how to use it

The tests provide both of those things. For extra bonus points, some documentation in the README would be great.

[69736c616d]

@mrtazz http://httpbin.org/delay/10 is not suitable for delete, post and put operations. Therefore i'm getting 405 from server. Can you suggest any other url ?

[mrtazz]

Ugh I remember there being an open issue to allow the route for all methods. In that case I think it's ok to only have the test for GET for now. And I'll keep an eye on httpbin to see if they implement that.

[mrtazz]

I just updated the unit test suite in master to also support JSON parsing (#25). So if you merge from master you should also be able to parse the JSON output you get back from httpbin

[mrtazz]

Thanks for taking the time to fixing this up! Looking good now!