return active class as valid HTML

this ended up appending the active css class directly to the HTML tag (e.g. <liclass='active'>) therefore rendering it invalid.
mrtazz · Dec 9, 2015 · 0d8e20f · 0d8e20f
1 parent 9f6e2ed
commit 0d8e20f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/phplib/Page.php b/phplib/Page.php
@@ -82,7 +82,7 @@ public function getActiveClassIfRequestMatches($requestUri)
     {
         $ret = "";
         if ($this->requestURI === $requestUri) {
-            $ret = "class='active'";
+            $ret = " class='active'";
         }
 
         return $ret;

diff --git a/tests/Page_tests.php b/tests/Page_tests.php
@@ -41,7 +41,7 @@ public function testGetFooter() {
 
     public function testGetActiveClassIfRequestMatches() {
 
-        $this->assertEquals("class='active'", $this->page->getActiveClassIfRequestMatches("/foo"));
+        $this->assertEquals(" class='active'", $this->page->getActiveClassIfRequestMatches("/foo"));
     }
 
     public function testGetTimeSelectBox() {