Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volcanos generate in custom dimensions (and may freeze the server) #72

Closed
izstas opened this issue Aug 17, 2013 · 5 comments
Closed

Volcanos generate in custom dimensions (and may freeze the server) #72

izstas opened this issue Aug 17, 2013 · 5 comments

Comments

@izstas
Copy link

izstas commented Aug 17, 2013

Volcanos generate in the Nether with Biomes O' Plenty installed (a lot of them, since the Nether is full of lava), and sometimes it causes server freeze for a relatively significant amount of time (enough to time out all connected players), and if I get Java thread dump, I see:

"Server thread" prio=6 tid=0x0000000013058800 nid=0x1ac8 runnable [0x000000001ac6e000]
java.lang.Thread.State: RUNNABLE
    at mrtjp.projectred.exploration.GeneratorVolcano.func_76484_a(GeneratorVolcano.java:31)
@MrTJP
Copy link
Owner

MrTJP commented Aug 17, 2013

World gen can't run in the nether. Unless you have another mod messing with nether worldgen, its not on my end. The very first thing the generator does is checks if its in the nether and returns.

@izstas
Copy link
Author

izstas commented Aug 17, 2013

Well, I do indeed have Biomes O' Plenty which replaces chunk provider. The check you have will probably generate volcanos in Twilight Forest and all Mystcraft ages too. I think checking dimension ID would not be a terrible idea.

Edited the issue title.

@izstas
Copy link
Author

izstas commented Aug 18, 2013

My thought are:

  • Generate ores only in dimension with ID = 0 or > 1
  • Generate volcanos and marble caves only in dimension with ID = 0
  • Maybe sometime later: Add Mystcraft symbols for volcanos and marble caves - that would be nice. I looked at Mystcraft API and it doesn't look hard to do.

@MrTJP
Copy link
Owner

MrTJP commented Aug 19, 2013

Volcanoes are now restricted to ID 0 and >1, and non hell biomes.
Mystcraft api is not open to the public.

@killjoy1221
Copy link

This issue also occurs with Natura when it overrides the nether worldgen. Disabling volcanoes or nethergen fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants