Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: SubSynth: Fix getting stuck in oscilloscope #56

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

AnClark
Copy link
Contributor

@AnClark AnClark commented Jun 22, 2021

In SubFX, once I switch to oscilloscope, I'll not be able to go back to
"Global" panel, as the envelope won't show anymore.
This patch should fix this problem: when click the "Global" tab button,
Zest should re-open the envelope view.

Reference: ZynPadSynth.qml (in src/mruby-zest/example)

NOTE: Maybe f21c3da should be dropped.

In SubFX, once I switch to oscilloscope, I'll not be able to go back to
"Global" panel, as the envelope won't show anymore.
This patch should fix this problem: when click the "Global" tab button,
Zest should re-open the envelope view.

Reference: ZynPadSynth.qml (in src/mruby-zest/example)
@fundamental
Copy link
Member

Thanks for the fix.

I'm not sure how this would resolve the issue in add synth though. I'm fine reverting the add synth commit and replacing it with the same change presented here, though I'm not sure that the behavior of claiming the oscilloscope is a visualization rather than a subview is correct, nor am I sure about it being correct that the tabs should get disabled when moving into the oscilloscope view. If there's anything behavior wise wrong with my commit let me know and I'll revert f21c3da as proposed.

@fundamental fundamental merged commit 5b81d6d into mruby-zest:master Jun 22, 2021
@AnClark
Copy link
Contributor Author

AnClark commented Jun 22, 2021

I'm not sure how this would resolve the issue in add synth though. I'm fine reverting the add synth commit and replacing it with the same change presented here

Add synth has no problem when I feedback. I only found bug in Sub synth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants