Honor CFLAGS and LDFLAGS on Linux #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makefile: Distributions use their own sets of CFLAGS and LDFLAGS, which should be honored when building.
dvzrv
changed the title
dvzrv
force-pushed
the
honor_cflags_ldflags
branch
from
4917c2e
to
037f5e2
Compare
|
Does this accomplish the base goal? Most of the compilation is controlled via the mruby/rake build system and the changes only impact the last step linking together stage. |
|
Hm. for my use-case it allowed me to achieve full RELRO (because LDFLAGS are honored). |
|
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makefile:
Distributions use their own sets of CFLAGS and LDFLAGS, which should be
honored when building.