Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curious about default MRB_PARSER_BUF_SIZE size #2724

Closed
djcas9 opened this issue Feb 16, 2015 · 4 comments
Closed

Curious about default MRB_PARSER_BUF_SIZE size #2724

djcas9 opened this issue Feb 16, 2015 · 4 comments

Comments

@djcas9
Copy link

djcas9 commented Feb 16, 2015

Why is this so small? 4656073

I'm currently using mruby as a plugin lang. https://github.com/mephux/clipby/blob/master/vm.go#L79 but the length of the data i'm pushing is causing this error. Am i just going about this incorrectly or was this limited for some other issue?

@matz
Copy link
Member

matz commented Feb 17, 2015

Could you show us the error message? I have removed array length limitation long ago, but there might be something left.

@matz
Copy link
Member

matz commented Feb 17, 2015

I just remembered that string literal length is kept in 16bit in compiled binary format. I thought it was ok to limit the string literal size. But you've shown us the need, I will support it in similar way we've handled longer arrays.

@matz
Copy link
Member

matz commented Feb 17, 2015

I opened #2725. If you don't have other limitation issues, close this one, and wait for the fix for #2725

@djcas9
Copy link
Author

djcas9 commented Feb 21, 2015

roger - thanks @matz

@djcas9 djcas9 closed this as completed Feb 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants