Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module#remove_method support duck-type #1979

Closed
wants to merge 3 commits into from
Closed

Module#remove_method support duck-type #1979

wants to merge 3 commits into from

Conversation

ksss
Copy link
Contributor

@ksss ksss commented Mar 29, 2014

I make two C function(to_sym and mrb_to_sym) that reason.

  • Module#remove_method should support duck-type
  • mrb_get_args('n') also

@matz
Copy link
Member

matz commented Mar 29, 2014

JIS/ISO requires symbols to specify methods names. Allowing strings gains nothing.
We should revert #1974 as well.

@matz matz closed this Mar 29, 2014
matz added a commit that referenced this pull request Mar 29, 2014
@matz
revert #1974; ref #1979
2277c37
@ksss ksss deleted the remove_method branch March 30, 2014 00:47
@ksss
Copy link
Contributor Author

ksss commented Mar 30, 2014

Ah, I don't know that.
Keep in mind.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ksss @matz