New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mrb_hash_ht_hash_func use mrb_obj_id() instead of mrb_sym2name_len() #2027

Closed

ksss wants to merge 1 commit into mruby:master from ksss:hash-symbol-key

Contributor

ksss commented Apr 8, 2014

hash[:symbol] is usecase of commonly-used.

But mrb_sym2name_len have cost that search symbol from n2s table.
And Symbol.object_id is never change.

I propose to use mrb_obj_id() when hash search symbol key.

Simplicity benchmark https://gist.github.com/ksss/10088148


          mrb_hash_ht_hash_func use mrb_obj_id() instead of mrb_sym2name_len()

2f739a8

matz closed this in

63cf707

ksss deleted the hash-symbol-key branch

April 13, 2014 12:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment