New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a check for 64 bit time_t overflow #2836

Closed

kext wants to merge 1 commit into mruby:master from kext:time-range-checks

Contributor

kext commented Jun 16, 2015

This should check for overflow on platforms where time_t is 64 bit.


          Added a check for 64 bit time_t overflow

8f643d1

kext reviewed

View reviewed changes

mrbgems/mruby-time/src/time.c

+                  /* Check for overflow of 64 bit time_t */
+                  (sizeof(time_t) == 8 && (sec > (double)INT64_MAX || (double)INT64_MIN > sec)) ||
+                  /* Check for wrapping of tm->sec */
+                  ((sec > 0 && tm->sec < 0) || (sec < 0 && (double)tm->sec > sec))

Contributor Author

kext Jun 16, 2015

I'm not sure, but this line might be a no-op, because signed overflow is undefined behavior.

matz closed this in

6a796cb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment