Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include time.h for ios #4941

Merged
merged 1 commit into from Feb 5, 2020
Merged

Include time.h for ios #4941

merged 1 commit into from Feb 5, 2020

Conversation

davidsiaw
Copy link
Contributor

An as-of-yet incomplete project of mine embedding mruby in iOS has revealed that struct timeval on recent versions of Darwin iOS is defined in sys/time.h.

This should have a minimal impact on other platforms.

If you wish to have a test for this I will be able to produce one in time. Currently I use a very hacked up xcode project file that includes a set of C files generated by mrbgems, and the project file is not fit for general consumption because it only includes a very specific set of mrbgems.

Once I have a working project file generation tool I will share it and this problem will become obvious, or if you have a minimal project using iOS you can see this issue.

I may be doing it wrong and could have been a build setting away from making mruby compile on iOS without this change, and would gladly take advice on how to proceed.

@matz matz merged commit 736ea1f into mruby:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants