Refactor the mrb_get_args() function
#5540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed the `ARGV` macro.
The current path doesn't go into the mruby VM and there's also no need to separate variables.
- Use common functions to check object types.
- Use `mrb_ensure_string_type()` to check the string instead of `mrb_to_str()`.
This is for consistency with array and hash.
- Use `mrb_ensure_array_type()` to check the array instead of `to_ary()`.
- Use `mrb_ensure_hash_type()` to check the hash instead of `to_hash()`.
- Add and use `ensure_class_type()` to check class and module.
- Changed the argument index type from `mrb_int` to `int`.
Even if it is `int16_t`, it is enough.
`mrb_int` is overkill, especially if `MRB_32BIT` and `MRB_INT64` are defined.
dearblue
added a commit
to dearblue/mruby
that referenced
this pull request
Dec 30, 2021
ref. mruby#5613. I mentioned in mruby#5540 that there was no reentrant to the virtual machine, but in fact it was still a possibility at that point. Also, the variable `ci` needs to be recalculated at the same time.
iwamatsu
pushed a commit
to mruby-debian/mruby
that referenced
this pull request
Jun 25, 2023
ref. mruby#5613. I mentioned in mruby#5540 that there was no reentrant to the virtual machine, but in fact it was still a possibility at that point. Also, the variable `ci` needs to be recalculated at the same time. [iwamatsu] backport to 3.0.0. This commit had been reverted by mruby@dfa21f2 in upstream. But However, this is because MR mruby#5622 merged the function. The patch is valid. Reference: CVE-2021-46020 Reference: mruby#5613 Reference: mruby@d3b7601 Reference: mruby#5620 Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@debian.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARGVmacro.The current path doesn't go into the mruby VM and there's also no need to separate variables.
mrb_ensure_string_type()to check the string instead ofmrb_to_str().This is for consistency with array and hash.
mrb_ensure_array_type()to check the array instead ofto_ary().mrb_ensure_hash_type()to check the hash instead ofto_hash().ensure_class_type()to check class and module.mrb_inttoint.Even if it is
int16_t, it is enough.mrb_intis overkill, especially ifMRB_32BITandMRB_INT64are defined.