Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare stub functions for libmruby_core in core #6024

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dearblue
Copy link
Contributor

The MRuby::Build#libmruby_core_only_objs accessor has been added for this purpose. It probably does not make sense for users to use this accessor.

And, the mruby-bin-mrbc/src/stub.c file has been moved to mruby/src/coreonly/stub.c. The object files generated from this file are passed to the newly created accessor.

The `MRuby::Build#libmruby_core_only_objs` accessor has been added for this purpose.
It probably does not make sense for users to use this accessor.

And, the `mruby-bin-mrbc/src/stub.c` file has been moved to `mruby/src/coreonly/stub.c`.
The object files generated from this file are passed to the newly created accessor.
@matz
Copy link
Member

matz commented Jun 24, 2023

I agree with the basic idea of this pull-request. But I don't like the directory name coreonly which role is not clear from the directory name.

@dearblue
Copy link
Contributor Author

Thanks for your comment.
🤔 Hmmm, is src/libmruby_core/ acceptable?

@matz
Copy link
Member

matz commented Jun 27, 2023

src/nogem maybe?

@dearblue
Copy link
Contributor Author

MRB_NO_GEMS may be defined in libmruby.a builds.

# build configuration
MRuby::Build.new do
  toolchain
end

Also, I don't think libmruby_core.a is very good about nogem since it doesn't include mruby/mrblib.

However, if you think src/nogem is OK, I will update this patch accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants