New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary `Rational._new` method #6149

Merged

matz merged 1 commit into mruby:master from dearblue:rational.new

Jan 20, 2024

Contributor

dearblue commented Jan 20, 2024

At this point, I would guess that it is definition only and probably not used from anywhere else.

% git grep -wn _new
mrbgems/mruby-rational/src/rational.c:774:  mrb_define_class_method(mrb, rat, "_new", rational_s_new, MRB_ARGS_REQ(2));


          Remove unnecessary Rational._new method

dearblue requested a review from matz as a code owner

January 20, 2024 13:06

github-actions bot added the mrbgems label

matz merged commit 028c53d into mruby:master

10 of 12 checks passed

dearblue deleted the rational.new branch

January 21, 2024 02:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment