Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub labeler: label more files #6205

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

jbampton
Copy link
Contributor

These are some of the config files for the linters/tests that run

@jbampton jbampton requested a review from matz as a code owner March 11, 2024 23:06
@jbampton
Copy link
Contributor Author

See in refs #6204 that the pull request was not labeled.

Best to have labels for all files / folders.

@dearblue
Copy link
Contributor

I think it's a bit different to belong to the build label.

🤔 Since I think the number is small and not a noteworthy classification, I propose miscellaneous and cast my vote.
Other label names I can think of are edit, coding, and utility.
If there is another preferred proposal, I may vote for that one.

@jbampton jbampton marked this pull request as draft March 15, 2024 15:12
@jbampton jbampton marked this pull request as ready for review March 23, 2024 18:33
These are some of the config files for the linters/tests that run
@jbampton
Copy link
Contributor Author

Thanks @dearblue I went with miscellaneous for the new label

@matz matz merged commit a7aa7a8 into mruby:master Mar 26, 2024
13 checks passed
@jbampton jbampton deleted the gha-label-more-files branch March 26, 2024 09:43
@jbampton
Copy link
Contributor Author

jbampton commented Apr 3, 2024

Hey @matz

I forgot to mention that we need to add the new label for miscellaneous on the repo labels page here:

https://github.com/mruby/mruby/labels

Thanks

@matz
Copy link
Member

matz commented Apr 3, 2024

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants