Revert "Adjust environment when mrb_exec_irep happened." - #6225
Merged
Conversation
This reverts commit 26e436e. After investigation, it is possible to revert by commit e89cc9b. The build configuration file used in the investigation is shown below. ```ruby MRuby::Build.new do |conf| toolchain :clang enable_debug enable_bintest enable_test cc.command = "clang18" linker.command = "clang18" [cc, cxx].each { |c| c.defines << "MRB_GC_STRESS" } [cc, cxx, linker].each { |cmd| cmd.flags << %w(-fsanitize=address) } gem github: "iij/mruby-dir" # rev: "89dceefa1250fb1ae868d4cb52498e9e24293cd1" gem github: "iij/mruby-env" # rev: "056ae324451ef16a50c7887e117f0ea30921b71b" gem github: "iij/mruby-errno" # rev: "b4415207ff6ea62360619c89a1cff83259dc4db0" gem github: "iij/mruby-require" # rev: "f0634d785e5cbb73cd7d118ee36deff499e4181e" gem github: "iij/mruby-tempfile" # rev: "9b883438547020dae328e34c8a2fe736171cd0ab" end ``` Since the `rake` command needs to be from the past, we used the Ruby 2.6 version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 26e436e.
After investigation, it is possible to revert by commit e89cc9b.
The build configuration file used in the investigation is shown below.
Since the
rakecommand needs to be from the past, we used the Ruby 2.6 version.