Free stack memory at end of fiber #6233
Merged
+42
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Immediately frees the call stack and data stack at the end of a non-root fiber. If the env object needs to be detached, the data stack is reused through `mrb_realloc()`. Previously, it was not necessary to take into account that `c->cibase` could be `NULL`. Note that this is no longer the case due to this patch. In fact, changes to "mruby-fiber" are now required.
matz
reviewed
Apr 11, 2024
| } | ||
| else { | ||
| mrb_assert(stack == env->stack); | ||
| mrb_write_barrier(mrb, (struct RBasic*)env); |
There was a problem hiding this comment.
Do we need mrb_write_barrier() here?
There was a problem hiding this comment.
Thanks for your review.
I am not sure exactly.
This fiber_terminate() is based on mrb_env_unshare().
It was removed from mrb_env_unshare() once, but was reintroduced in commit 93648fc, so I added it.
There was a problem hiding this comment.
Oh, I see. I investigated and found out we need it. Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Immediately frees the call stack and data stack at the end of a non-root fiber.
If the env object needs to be detached, the data stack is reused through
mrb_realloc().Previously, it was not necessary to take into account that
c->cibasecould beNULL.Note that this is no longer the case due to this patch.
In fact, changes to "mruby-fiber" are now required.