Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of second argument of Regexp.new. #874

Closed
wants to merge 1 commit into from
Closed

Fix handling of second argument of Regexp.new. #874

wants to merge 1 commit into from

Conversation

masamitsu-murase
Copy link
Contributor

I think that second argument of Regexp.new should be Integer according to ISO spec.

@masamitsu-murase
Copy link
Contributor Author

If this patch is acceptable, I think that re.h should be moved to include/mruby/re.h so that external Regexp mgem can include re.h.

@mattn
Copy link
Contributor

mattn commented Feb 25, 2013

sounds good to me.

@monaka
Copy link
Contributor

monaka commented Apr 2, 2013

👍

@monaka
Copy link
Contributor

monaka commented Apr 2, 2013

Basically, I like this patch. And some comments.

  • There should raise error when there is a letter except 'x', 'i', or 'm'. As CRuby works so.
  • As far as I know, 'x' flag is not ISO specified.

@matz
Copy link
Member

matz commented Dec 21, 2018

Option check has been added.

@matz matz closed this Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@masamitsu-murase @mattn @monaka @matz