Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sixel encoder option #14

Merged
merged 3 commits into from
Aug 4, 2023
Merged

Add sixel encoder option #14

merged 3 commits into from
Aug 4, 2023

Conversation

AbeEstrada
Copy link
Contributor

This implements the sixel encoder option (#12), only supported on iTerm2 and WezTerm (I also tested Kitty and Alacritty) at the moment and it is not compatible with any pager like less, more, most.

I really wanted better images, but it is very limited. I added the option as an exercise, feel free to close this PR if it doesn't get enough attention.

@AbeEstrada
Copy link
Contributor Author

Alacritty: Add support for libsixel #910

Copy link
Owner

@mrusme mrusme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! TODO for the future: Since we're pulling in http.Get with this change, it would make sense to consolidate the image retrieval for ANSI and Sixel to a single place and make ansimage use the retrieved image, instead of using NewScaledFromURL.

@mrusme mrusme added the enhancement New feature or request label Aug 3, 2023
@mrusme
Copy link
Owner

mrusme commented Aug 3, 2023

Thank you @AbeEstrada! Would you mind adding a usage info plus maybe a small screenshot of how the -s option's output looks like to the README.md? You can add the file to the root dir as sixel.png or something.

@AbeEstrada
Copy link
Contributor Author

@mrusme updated the README and added the screenshot.

I'm going to leave this https://www.arewesixelyet.com here for reference.

@mrusme mrusme merged commit 0d53289 into mrusme:master Aug 4, 2023
@mrusme
Copy link
Owner

mrusme commented Aug 4, 2023

Thank you very much @AbeEstrada!

FYI: New release (v0.4.3) that contains your PR is currently building (https://github.com/mrusme/reader/actions/runs/5764298168) and should be out in a few minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants