-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python3 #187
Merged
Merged
Python3 #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes to make "Log Report" button work again
Per our discussion with previous changes
Changes per our discussion
Add same logic to python3 branch for issue mrworf#182
Fix for python3 branch for handling images set to Do Nothing or to Fill
added codecs library and modified code to translate bytes to string for json.load
Updated to describe this branch specifically.
Bring up to date with mrworf master/python3 version
Added Ability to make use of alternate TCS34727 color sensor on a different module. This module has a better physical design than the Adafruit module, and works the same, except it has a version ID of 77 (0x4D) instead of 68 (0x44). It was bought on eBay: https://www.ebay.com/itm/133600154256
Updated description of alternate color module
Added Code to support HEIC and HEIF images.
Spelling and grammar
fix syntax error
Indent error for Copy/paste
Moved HEIC to JPG conversion from makeFullframe to Autorotate in order to catch a missing case where a HEIC was set to do nothing but changed colors when cropped to fit the screen.
Colormatch had some questionable logic at low lux levels. The changes allow temperature to be calculated as long as all the colors are not 0. And also, when there is NO light, zero temperature is probably not correct, rather make a middle-of-the-road assumption.
Modified to detect and control monitors that can be adjusted using ddc channel. These will change brightness and temperature, and not require the colormatch script.
Added check to avoid going higher in temp than a monitor can support
Syntax changes
Syntax
More Syntax - I need to try an IDE!
temp and lux were not set when levels were zero
Make scale adjustments
move logic to suppress script adjustment to slidephow.py to avoid logging a warning for each picture. Also clean up legacy updates in update.sh. All those will have been applied in this branch.
Formatting and URL port 7777
spelling
Added instructions to add http-auth.json for a manual install.
New color logic and move server to port 80.
Allow configuring a scaler to set Monitor brightness from lux
partial commit to run from port 80
Added Install step for update crontab file
Ignore hidden files (those that start with "."
Philip updates to Python3 branch
Made changes to re-purpose the Philip branch readme to this one.
Removed Migration.md and minor updates to Readme
Install and update from python3 branch
This was referenced Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this set of commits completes obvious fixes for python 3 to work. I'm not very good at Github, and did not figure out how to get your commits to services/svc_googlephotos.py pulled back into my python3 branch - so BOLO for those.
I think this seems to get it completely functional, including adding and deleting all options and services, creating an auth for google at sensenet, +- keywords, display resolution and rotation, etc. Tested on 3B+ and 0w with lux module. The only thing I have not tested is the off switch and a directly-attached (non-hdmi) display.