Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Models' forward are incorrect #2

Closed
sagarwaghmare69 opened this issue Mar 16, 2017 · 3 comments
Closed

Models' forward are incorrect #2

sagarwaghmare69 opened this issue Mar 16, 2017 · 3 comments

Comments

@sagarwaghmare69
Copy link
Contributor

Hey just realized that the model forward/sequence is wrong.
E.g
Current code:
input is (nc) x 256 x 256

e1 = self.conv1(input)
# input is (ngf) x 128 x 128
e2 = self.batch_norm2(self.conv2(self.leaky_relu(e1)))

This should be
input is (nc) x 256 x 256

e1 = self.conv1(input)
# input is (ngf) x 128 x 128
e2 = self.conv2(self.leaky_relu(self.batch_norm2(e1)))

Hence both the discriminator and generator models are incorrect.

@mrzhu-cool
Copy link
Owner

Hey, I checked the code carefully today.
The model construction seems to have no wrong.
It's structure is the same as the original lua torch code.
A little mistake is that I forgot a leaky_relu layer after h4 in netD.

@sagarwaghmare69
Copy link
Contributor Author

sagarwaghmare69 commented Mar 17, 2017 via email

@sagarwaghmare69
Copy link
Contributor Author

Nice. Thanks. Let me know if the results improve.
Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants