Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to include a signature, conditionally. #21

Closed
wants to merge 5 commits into from

Conversation

the-solipsist
Copy link
Contributor

@the-solipsist the-solipsist commented Nov 18, 2020

I've added an option to conditionally include a signature. I've changed the template, the yaml file, as well as the readme to provide instructions on how to use it.

@mrzool
Copy link
Owner

mrzool commented Nov 22, 2020

Not sure about this one… who puts a signature on an invoice? I never had to send out a signed invoice nor ever received one. Couldn't find a country where signing invoices is required by law. Seems unnecessary to be honest.

@mrzool mrzool closed this Nov 22, 2020
@the-solipsist
Copy link
Contributor Author

In India, it is mandatory to have signed invoices (either through a pen-and-paper signature or through a digital (cryptographic) signature) for tax purposes, and there's software to help you do that as well.

@the-solipsist
Copy link
Contributor Author

And further, if there's a closingnote, then it makes sense to allow for an optional signature even in contexts where a signature isn't legally mandated.

@mrzool
Copy link
Owner

mrzool commented Nov 22, 2020

My bad, looks like I didn't search hard enough. I'll have another look at this asap, reopening in the meantime.

@mrzool mrzool reopened this Nov 22, 2020
@mrzool
Copy link
Owner

mrzool commented Nov 29, 2020

Ended up implementing this myself in 7569fde, without adding any additional option, consistent with how the same feature is implemented in letter-boilerplate.

Thanks for the input!

@mrzool mrzool closed this Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants