[Firmata] missing void startSysex(void) method

[zfields]

No description provided.

[ooeygui]

Can you supply information as to why it is needed?

[turkycat]

Firmata.cpp calls it "startSysex" / "endSysex" while I named it "beginSysex" / "endSysex" in UwpFirmata. I agree that it should have matched the latter, but not sure if we should change it now?

[zfields]

We are trying to provide a familiar API surface, so we should at least have parity. I would take the logic from beginSysex(), move it startSysex(), then have beginSysex() call startSysex() and deprecate beginSysex().

[turkycat]

We should revisit this issue. New UwpFirmata implementation does not use startSysex() or endSysex(). New function signatures are:

[Windows::Foundation::Metadata::DefaultOverload]
void
sendSysex(
        SysexCommand command_,
        IBuffer ^buffer_
    );

and

void
    sendSysex(
        uint8_t command_,
        IBuffer ^buffer_
    );

which allow the entire IBuffer to be sent at once. No more need to invoke 3 functions for one concept. It does not perfectly match the Firmata API (as this issue was meant to resolve) but is arguably more sensible on our platform.

[zfields]

I'll close this issue. The original observation is no longer valid.