Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Cannot start daemon when ROS_DOMAIN_ID is specified in environment variable #724

Closed
1 task done
hayato-m126 opened this issue May 17, 2022 · 0 comments · Fixed by #729
Closed
1 task done
Labels
bug Something isn't working

Comments

@hayato-m126
Copy link

hayato-m126 commented May 17, 2022

  • ROS 2: galactic

<Version of the plugin>
v0.8.2

<Copy the Version information from the Help | About menu>
1.67.1

what is the bug

<current behavior>
When ROS_DOMAIN_ID is specified in the environment variable, the plugin's daemon status is always offine even if ros2 daemon status is running in shell.

Repro steps

<how to reproduce the bug. Please attach sample files or github repo if appropriate.>

  1. add ROS_DOMAIN_ID to .bashrc
  • echo "export ROS_DOMAIN_ID=77" >> ~/.bashrc
  1. open ros workspace with vscode
  2. Ctrl+Shit+P ROS: Start
  3. Ctrl+Shit+P ROS: Show Status

expected behavior

<what you would expect to happen>
daemon status is online even if ROS_DOMAIN_ID is set

additional context

<any additional information would be helpful for a better understanding>
I think function getDaemonPort have to add ROS_DOMAIN_ID.

plugin code

let basePort: number = 11511;

cli code
https://github.com/ros2/ros2cli/blob/f4e5952f430e502060594d68f3a050b785fd4249/ros2cli/ros2cli/daemon/__init__.py#L35

@hayato-m126 hayato-m126 added the bug Something isn't working label May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant