Allow to rename when paths exist in copy/ cut operations #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, I will add this in tomorrow. Just came from from a long break due to a bunch of things happening in personal life. |
This was referenced Oct 18, 2020
|
going to finish doing #84, before I merge this one, |
Thank you :D |
|
sorry about the long wait, i had some stressful things going on in my life |
schmijos
reviewed
Jun 8, 2022
| if new_dest: | ||
| operations[source] = new_dest | ||
| else: | ||
| return None |
There was a problem hiding this comment.
@ms-jpq wouldn't it be nice to ask wether it's ok to replace the existing files instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thank you for this wonderful project.
I usually face the problem when copy/cut items to a folder that already exists.
In this pull request, it just allows the user to rename folder/ files if the destination file/folder already exists.