Merge pull request #1365 from ms609/GlazerMann-patch-15

Done: Report url dropping
ms609 · Feb 25, 2019 · 1909168 · 1909168
2 parents f0cc8a8 + d430fd3
commit 1909168
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/Page.php b/Page.php
@@ -291,6 +291,21 @@ public function edit_summary() {
         $auto_summary = substr($auto_summary, 0, -2) . '. ';
       }
     }
+
+    if ((count($this->modifications["deletions"]) !== 0)
+    && (
+        (($pos = array_search('url', $this->modifications["deletions"])) !== FALSE)
+     || (($pos = array_search('chapter-url', $this->modifications["deletions"])) !== FALSE)
+     || (($pos = array_search('chapterurl', $this->modifications["deletions"])) !== FALSE)
+        )
+    ) {
+        if (strpos($auto_summary, 'chapter-url') !== FALSE) {
+          $auto_summary .= "Removed or converted URL. ";
+        } else {
+          $auto_summary .= "Removed URL that duplicated unique identifier. ";
+        }
+        unset($this->modifications["deletions"][$pos]);
+    }
     if ((count($this->modifications["deletions"]) !== 0)
     && ($pos = array_search('accessdate', $this->modifications["deletions"])) !== FALSE
     ) {

diff --git a/tests/phpunit/PageTest.php b/tests/phpunit/PageTest.php
@@ -15,13 +15,16 @@ public function testPageChangeSummary() {
       $this->assertEquals('Misc citation tidying. | You can [[WP:UCB|use this bot]] yourself. [[WP:DBUG|Report bugs here]].',$page->edit_summary());
       $page = $this->process_page('<ref>http://onlinelibrary.wiley.com/doi/10.1111/j.1475-4983.2012.01203.x</ref>');
       $this->assertFalse(strpos($page->parsed_text(), 'onlinelibrary.wiley.com')); // URL is gone
-      $this->assertEquals('Alter: template type. Add: year, pages, issue, volume, journal, title, doi, author pars. 1-2. Converted bare reference to cite template. Removed parameters. Formatted [[WP:ENDASH|dashes]]. | You can [[WP:UCB|use this bot]] yourself. [[WP:DBUG|Report bugs here]].' ,$page->edit_summary());                
+      $this->assertEquals('Alter: template type. Add: year, pages, issue, volume, journal, title, doi, author pars. 1-2. Removed URL that duplicated unique identifier. Converted bare reference to cite template. Formatted [[WP:ENDASH|dashes]]. | You can [[WP:UCB|use this bot]] yourself. [[WP:DBUG|Report bugs here]].' ,$page->edit_summary());                
       $page = $this->process_page('{{cite web|<!-- comment --> journal=Journal Name}}'); // Comment BEFORE parameter
       $this->assertEquals('Alter: template type. | You can [[WP:UCB|use this bot]] yourself. [[WP:DBUG|Report bugs here]].',$page->edit_summary());
       $this->assertEquals('{{cite journal|<!-- comment --> journal=Journal Name}}', $page->parsed_text());
       $page = $this->process_page('{{cite web|journal<!-- comment -->=Journal Name}}'); // Comment AFTER parameter
       $this->assertEquals('Alter: template type. | You can [[WP:UCB|use this bot]] yourself. [[WP:DBUG|Report bugs here]].',$page->edit_summary());
       $this->assertEquals('{{cite journal|journal<!-- comment -->=Journal Name}}', $page->parsed_text());
+      $page = $this->process_page('{{cite book|url=http://a.fake.url.fake/|chapter=Chap|title=Title}}');
+      $this->assertEquals('{{cite book|chapter-url=http://a.fake.url.fake/|chapter=Chap|title=Title}}', $page->parsed_text());
+      $this->assertEquals('Add: chapter-url. Removed or converted URL. | You can [[WP:UCB|use this bot]] yourself. [[WP:DBUG|Report bugs here]].' ,$page->edit_summary());
   }
 
   public function testBotRead() {