Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 5.6 does not support const arrays #177

Closed
ms609 opened this issue Sep 29, 2017 · 1 comment
Closed

PHP 5.6 does not support const arrays #177

ms609 opened this issue Sep 29, 2017 · 1 comment
Assignees

Comments

@ms609
Copy link
Owner

ms609 commented Sep 29, 2017

Code needs re-writing to be compatible with PHP 5.6, or better still PHP5.5.9, as this is what is run on the wmflabs machine.

@ms609
Copy link
Owner Author

ms609 commented Sep 29, 2017

Re-writing define()s as consts provides PHP 5.6 compatibility (and has positive performance implications too)

@ms609 ms609 closed this as completed Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant