Older PHP does not support const arrays. #170
Conversation
|
Seems to me that the test environment might need to match the Wiki PHP version. |
|
Oh dear - I'd assumed (hoped) that wmflabs were running PHP7. The code will require some significant refactoring otherwise - you can't |
|
It is 5.5.9. Old 👵🏻👴🏻 |
|
That's frustrating. What is the prospect of them upgrading to PHP7? For now, I've added 5.5.9 to the Travis test cases, but it will take some work to re-adapt the code; probably the thing to do is to make a public function |
|
Fighting this issue in wiki land |
|
5.6 is supported sort of. Check Wikipedia talk page. |
|
I believe that PHP7 is the first version to allow const arrays. |
|
Actually 5.6 supports it. It appears that it was considered useful enough to add. That’s the last pre-7 version. |
|
Oh, great! Are you able to see what is needed to force the use of this
version?
…--
*Martin R. Smith*
Assistant Professor in Palaeontology
Department of Earth Sciences
Durham University
Mountjoy Site, South Road
Durham DH1 3LE
*T*: +44 191 334 2320
*M*: +44 774 353 7510
*E*: martin.smith@durham.ac.uk
*Skype*: martin--smith
durham.ac.uk/earth.sciences/staff/academic/?id=14260
twitter.com/PalaeoSmith
The information in this e-mail and any attachments is confidential. It is
intended solely for the addressee or addressees. If you are not the
intended recipient please delete the message and any attachments and notify
the sender of mis-delivery. Any use or disclosure of the contents of either
is unauthorised and may be unlawful.
Although steps have been taken to ensure that this e-mail and any
attachments are free from any virus, we advise the recipient to ensure they
are indeed virus free. All liability for viruses is excluded to the fullest
extent permitted by law.
On 27 September 2017 at 17:28, GlazerMann ***@***.***> wrote:
Actually 5.6 supports it. It appears that it was considered useful enough
to add. That’s the last pre-7 version.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#170 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABnfG6_2zkh-ioE1PepcwXTvakPWJUssks5smnfBgaJpZM4PenxY>
.[image: Web Bug from
https://github.com/notifications/beacon/ABnfG7w7_JuAiO0OR4loQByIcttemRb-ks5smnfBgaJpZM4PenxY.gif]
{"api_version":"1.0","publisher":{"api_key":"
05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":
{"external_key":"github/ms609/citation-bot","title":"ms609/
citation-bot","subtitle":"GitHub repository","main_image_url":"
https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-
11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://
cloud.githubusercontent.com/assets/143418/15842166/
7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in
GitHub","url":"https://github.com/ms609/citation-bot"}},"
***@***.*** in #170:
Actually 5.6 supports it. It appears that it was considered useful enough
to add. That’s the last pre-7 version."}],"action":{"name":"View Pull
Request","url":"https://github.com/ms609/citation-bot/
pull/170#issuecomment-332578930"}}}
|
|
https://wikitech.wikimedia.org/wiki/Help:Toolforge/Kubernetes#Versions_.26_Packages Yeah it means using a container. It’s not just a flag. This discussion is probably better on Wikipedia |
|
@GlazerMann: Something seems to be messed up with the Kubernetes set up on Toolforge. I haven't been able to get it running at all. |
|
@GlazerMann: Finally managed to get it working (I think). See if the dev code works now. |
|
The dev code does not work as far as I can tell. What types of errors do you get. As a user, we do not see the erros |
|
Once we have the error messages; we can fix PHP Code to work with 5.6 |
|
Even in PHP 5.6, constants must evaluate to scalar values: see Looks like the code will have to be refactored. This might be something I can have a bash at today. |
|
Please direct any further discussion on this topic to the related issue. |
Probably better to update PHP on Wiki Tools to match test environment.