New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert last3=et. al. to display-authors = etal #1302
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1302 +/- ##
=========================================
Coverage ? 81.25%
Complexity ? 1823
=========================================
Files ? 10
Lines ? 3931
Branches ? 0
=========================================
Hits ? 3194
Misses ? 737
Partials ? 0
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1302 +/- ##
============================================
+ Coverage 81.19% 81.23% +0.04%
- Complexity 1819 1824 +5
============================================
Files 10 10
Lines 3924 3933 +9
============================================
+ Hits 3186 3195 +9
Misses 738 738
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you confident that this works as expected? I.e. if an article had 20 authors, and a lazy editor had only written the first two, will the template still display the "et al"?
(Presumably that is what the etal
value does, but that didn't used to exist back in the day...)
@ms609 the display=etal is fairly new. This only fixes cases where editors list the last author at etal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, well let's give it a go, but do keep a careful eye that the output renders as expected on WP!
No description provided.