Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert last3=et. al. to display-authors = etal #1302

Merged
merged 9 commits into from Feb 11, 2019
Merged

Conversation

GlazerMann
Copy link
Collaborator

No description provided.

@GlazerMann GlazerMann requested a review from ms609 February 7, 2019 21:31
Repository owner deleted a comment from codecov bot Feb 8, 2019
Repository owner deleted a comment from codecov bot Feb 8, 2019
@codecov
Copy link

codecov bot commented Feb 9, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@cf60f0b). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1302   +/-   ##
=========================================
  Coverage          ?   81.25%           
  Complexity        ?     1823           
=========================================
  Files             ?       10           
  Lines             ?     3931           
  Branches          ?        0           
=========================================
  Hits              ?     3194           
  Misses            ?      737           
  Partials          ?        0
Impacted Files Coverage Δ Complexity Δ
Template.php 81.63% <100%> (ø) 1711 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf60f0b...8246d86. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 9, 2019

Codecov Report

Merging #1302 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1302      +/-   ##
============================================
+ Coverage     81.19%   81.23%   +0.04%     
- Complexity     1819     1824       +5     
============================================
  Files            10       10              
  Lines          3924     3933       +9     
============================================
+ Hits           3186     3195       +9     
  Misses          738      738
Impacted Files Coverage Δ Complexity Δ
Template.php 81.65% <100%> (+0.06%) 1712 <5> (+5) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf60f0b...daedd7f. Read the comment docs.

@GlazerMann GlazerMann changed the title convert last3=et. al. to display-authors = etal convert last3=et. al. to displayauthors = etal Feb 9, 2019
@GlazerMann GlazerMann changed the title convert last3=et. al. to displayauthors = etal convert last3=et. al. to display-authors = etal Feb 9, 2019
@GlazerMann GlazerMann changed the title convert last3=et. al. to display-authors = etal convert last3=et. al. to displayauthors = etal Feb 9, 2019
@GlazerMann GlazerMann changed the title convert last3=et. al. to displayauthors = etal convert last3=et. al. to display-authors = etal Feb 9, 2019
Copy link
Owner

@ms609 ms609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you confident that this works as expected? I.e. if an article had 20 authors, and a lazy editor had only written the first two, will the template still display the "et al"?

(Presumably that is what the etal value does, but that didn't used to exist back in the day...)

@GlazerMann
Copy link
Collaborator Author

@ms609 the display=etal is fairly new. This only fixes cases where editors list the last author at etal.

Copy link
Owner

@ms609 ms609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, well let's give it a go, but do keep a careful eye that the output renders as expected on WP!

@GlazerMann GlazerMann merged commit 57eabca into master Feb 11, 2019
@GlazerMann GlazerMann deleted the GlazerMann-patch-6 branch February 11, 2019 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants