Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSTOR sometimes sends first page as end page too #1384

Merged
merged 1 commit into from Feb 26, 2019
Merged

Conversation

GlazerMann
Copy link
Collaborator

@GlazerMann GlazerMann commented Feb 26, 2019

GIGO protection. This might seem silly, since pages=33-33 gets fixed later, but this means the existing page=33 gets changed to pages=33-33 and then to pages=33, which is a cosmetic change.

@codecov
Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #1384 into master will increase coverage by 2.96%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1384      +/-   ##
============================================
+ Coverage     78.31%   81.28%   +2.96%     
- Complexity     1839     1840       +1     
============================================
  Files            10       10              
  Lines          3975     3975              
============================================
+ Hits           3113     3231     +118     
+ Misses          862      744     -118
Impacted Files Coverage Δ Complexity Δ
Template.php 81.46% <100%> (+4.62%) 1724 <0> (+1) ⬆️
expandFns.php 96.62% <0%> (ø) 0% <0%> (ø) ⬇️
DOItools.php 97.2% <0%> (+2.79%) 0% <0%> (ø) ⬇️
user_messages.php 60.86% <0%> (+8.69%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc306db...da63f63. Read the comment docs.

@ms609 ms609 merged commit b584898 into master Feb 26, 2019
@GlazerMann GlazerMann deleted the GlazerMann-patch-9 branch February 26, 2019 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants