Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MEDIUM PRIORITY: template cite is a real thing-convert it #1401

Merged
merged 2 commits into from Mar 5, 2019
Merged

MEDIUM PRIORITY: template cite is a real thing-convert it #1401

merged 2 commits into from Mar 5, 2019

Conversation

GlazerMann
Copy link
Collaborator

@GlazerMann GlazerMann commented Feb 28, 2019 •
edited

It is an alias for citation.

This went away over a decade ago: you were part of it.

@GlazerMann GlazerMann changed the title template cite is a real thing-support it template cite is a real thing-convert it Feb 28, 2019
@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@800829b). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1401   +/-   ##
=========================================
  Coverage          ?   81.69%           
  Complexity        ?     1857           
=========================================
  Files             ?       10           
  Lines             ?     4010           
  Branches          ?        0           
=========================================
  Hits              ?     3276           
  Misses            ?      734           
  Partials          ?        0
Impacted Files Coverage Δ Complexity Δ
Template.php 81.98% <100%> (ø) 1741 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 800829b...ef7906c. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 28, 2019 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@800829b). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1401   +/-   ##
=========================================
  Coverage          ?   81.69%           
  Complexity        ?     1857           
=========================================
  Files             ?       10           
  Lines             ?     4010           
  Branches          ?        0           
=========================================
  Hits              ?     3276           
  Misses            ?      734           
  Partials          ?        0
Impacted Files Coverage Δ Complexity Δ
Template.php 81.98% <100%> (ø) 1741 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 800829b...ef7906c. Read the comment docs.

@GlazerMann GlazerMann changed the title template cite is a real thing-convert it MEDIUM: template cite is a real thing-convert it Mar 1, 2019
@GlazerMann GlazerMann changed the title MEDIUM: template cite is a real thing-convert it MEDIUM PRIORITY: template cite is a real thing-convert it Mar 2, 2019
@ms609 ms609 merged commit 6b61a78 into master Mar 5, 2019
@GlazerMann GlazerMann deleted the GlazerMann-patch-8 branch March 5, 2019 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ms609 ms609 ms609 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GlazerMann @ms609