VERY HIGH PRIORITY: Fixes to page() make this check not needed anymore #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1404 +/- ##
=========================================
Coverage ? 81.58%
Complexity ? 1855
=========================================
Files ? 10
Lines ? 4008
Branches ? 0
=========================================
Hits ? 3270
Misses ? 738
Partials ? 0Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1404 +/- ##
=========================================
Coverage ? 81.58%
Complexity ? 1855
=========================================
Files ? 10
Lines ? 4008
Branches ? 0
=========================================
Hits ? 3270
Misses ? 738
Partials ? 0Continue to review full report at Codecov.
|
GlazerMann
changed the title
GlazerMann
changed the title
GlazerMann
changed the title
ms609
approved these changes
Mar 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But leave check for empty data just in case
For so reason, the "new" code was not working perfectly either when no changes were made. Odd