Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant bibcode URLs #1419

Merged
merged 1 commit into from Mar 7, 2019
Merged

remove redundant bibcode URLs #1419

merged 1 commit into from Mar 7, 2019

Conversation

GlazerMann
Copy link
Collaborator

@GlazerMann GlazerMann commented Mar 6, 2019

Existing code does not drop urls if the bibcode parameter is set already.
New code drops url (only after making sure the new and old bibcode match of course).

@GlazerMann GlazerMann requested a review from ms609 March 6, 2019 16:30
@codecov
Copy link

codecov bot commented Mar 6, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@6748cf6). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1419   +/-   ##
=========================================
  Coverage          ?   81.87%           
  Complexity        ?     1861           
=========================================
  Files             ?       10           
  Lines             ?     4017           
  Branches          ?        0           
=========================================
  Hits              ?     3289           
  Misses            ?      728           
  Partials          ?        0
Impacted Files Coverage Δ Complexity Δ
Template.php 82.04% <0%> (ø) 1744 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6748cf6...a333189. Read the comment docs.

@GlazerMann GlazerMann merged commit 8e8cdad into master Mar 7, 2019
@GlazerMann GlazerMann deleted the GlazerMann-patch-2 branch March 7, 2019 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants